Skip to content

test(bigquery): add tests for TableRow 'f' field conflict issue - #36394

Closed
liferoad wants to merge 1 commit into
apache:masterfrom
liferoad:add-bq-f-tests
Closed

test(bigquery): add tests for TableRow 'f' field conflict issue#36394
liferoad wants to merge 1 commit into
apache:masterfrom
liferoad:add-bq-f-tests

Conversation

@liferoad

@liferoad liferoad commented Oct 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add test cases to reproduce and document the IllegalArgumentException when setting non-List values to the 'f' field in TableRow objects. These tests demonstrate the type conflict between user-defined 'f' columns and BigQuery's internal 'f' field, and verify the workaround using List.

Tests for #33531

./gradlew :sdks:java:io:google-cloud-platform:test --tests "org.apache.beam.sdk.io.gcp.bigquery.TableRowFieldFIssueTest" --info --rerun-tasks

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@liferoad
test(bigquery): add tests for TableRow 'f' field conflict issue
7fcfde5 
Add test cases to reproduce and document the IllegalArgumentException when setting non-List values to the 'f' field in TableRow objects. These tests demonstrate the type conflict between user-defined 'f' columns and BigQuery's internal 'f' field, and verify the workaround using List<TableCell>.
@gemini-code-assist

gemini-code-assist Bot commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @liferoad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive set of tests to address a known issue in Apache Beam's BigQuery I/O connector. The primary goal is to reproduce and document the IllegalArgumentException that arises when users inadvertently define a column named 'f' in TableRow objects with a non-List data type, which clashes with BigQuery's internal representation. The added tests not only highlight the problem but also confirm the efficacy of the recommended workaround, ensuring better understanding and stability for users encountering this specific field conflict.

Highlights

  • Reproduce IllegalArgumentException: Added new test cases to reliably reproduce the IllegalArgumentException that occurs when non-List values are assigned to a user-defined column named 'f' in TableRow objects, conflicting with BigQuery's internal 'f' field.
  • Document Type Conflict: The tests specifically demonstrate the type conflict arising from user-defined 'f' columns and BigQuery's internal 'f' field, covering scenarios with Double, String, and Integer values.
  • Verify Workaround: Included tests to verify that the existing workaround, which involves using List<TableCell> for the 'f' field via the setF() method, correctly prevents the IllegalArgumentException.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions

github-actions Bot commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@liferoad

liferoad commented Oct 7, 2025

Copy link
Copy Markdown
Contributor Author

Close this since this just demonstrates how the workarounds could work for TableRowToStorageApiProto.messageFromTableRow.

@liferoad liferoad closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

gcp io java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@liferoad